Closed michael-valdron closed 5 days ago
- Add Eclipse Che team by either of the following methods:
- Add Eclipse Che team GitHub group under
CODEOWNERS
file for all stacks (as should be for Devfile Services Team if this is done)- Add every member of Eclipse Che team in
stacks/OWNERS
file underreviewers
Best to investigate which one of these works best first and choose the one that does.
Trying to investigate the group solution and if we can have one approval per group. Will share an example from my fork soon.
I've tried to look into a possible solution that requires approval from 2 CODEOWNERS coming from two different groups of users (eclipse che
& the stack owners). Sharing here my suggested approach.
eclipse che
group in the devfiles org and give them write access.eclipse che
group code owners of the stacks/
directory.
- [ ] Add Eclipse Che team by either of the following methods:
- Add Eclipse Che team GitHub group under
CODEOWNERS
file for all stacks (as should be for Devfile Services Team if this is done)- Add every member of Eclipse Che team in
stacks/OWNERS
file underreviewers
Given the decision from today's team meeting, we've decided to use the CODEOWNERS
file instead of the current OWNERS
files for handling reviewer teams and stack owners, this matches @thepetk's current direction for this issue: https://github.com/devfile/api/issues/1498#issuecomment-2061457820
Will update the criteria in the description to match this.
Created issue https://github.com/devfile/api/issues/1538 in order to add a new workflow job to check all updated stacks against dev workspaces
Opened a PR to update the CODEOWNERS & OWNERS files. Also added a process for this section inside the contributing guide.
Which area/kind this issue is related to?
/kind task
/area registry
Issue Description
Since Eclipse Che now uses the community devfile registry directly to acquire stacks for creating workspaces, we'll need to include the Eclipse Che team as reviewers to sign off on any stack changes by us, the community, or the Che team themselves which is now included under the Eclipse Che software by default.
Acceptance Criteria
CODEOWNERS
file for all stacks (as should be for Devfile Services Team if this is done)