search

devfile / api

Kube-native API for cloud development workspaces specification
Apache License 2.0
262 stars 63 forks source link

Sync Devfile Registry and Helm Chart Ingress Handling #1539

Open Jdubrick opened 6 months ago

Jdubrick commented 6 months ago

Which area/kind this issue is related to?

/area registry

Issue Description

After completion of https://github.com/devfile/api/issues/1520 we need to sync the way the Operator and the Helm chart deployments handle a missing Ingress domain. With the new changes to the Operator if an Ingress domain is not entered the creation of that resource is skipped and a log is output to communicate why it was skipped. Additionally, the fqdn is then set to http://localhost:8080 as a default as without an Ingress it won't be communicating outside of the cluster.

Changes made to the operator can be found here: https://github.com/devfile/registry-operator/pull/89

Acceptance Criteria

github-actions[bot] commented 2 days ago

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.