Closed l0rd closed 2 years ago
LGTM
@metacosm: changing LGTM is restricted to collaborators
I approve.
Jingfu Wang Red Hat Software Engineer Email: @.***
On Tue, Jul 20, 2021 at 7:02 AM Mario Loriedo @.***> wrote:
What does this PR do?
We are about to propose Devfile as a CNCF sandbox project. Most of the CNCF projects are licensed under Apache-2.0 and that’s what the community is used to. Re-licensing to Apache-2.0 would make the process smoother and augment our chances to successfully transition the project to CNCF sandbox. Both EPL-2.0 and Apache-2.0 are open source licenses that are widely used in the industry and Apache-2.0 is considered more permissive than EPL-2.0.
⚠️ This PR is in draft mode. We are contacting existing contributors to get their approval and then we will merge it. What issues does this PR fix or reference?
426 https://github.com/devfile/api/issues/426
Contributors list (checked ones have approved the re-licensing)
- @nickboldt https://github.com/nickboldt
- @musienko-maxim https://github.com/musienko-maxim
- @GeekArthur https://github.com/GeekArthur
- @sunix https://github.com/sunix
- @girishramnani https://github.com/girishramnani
- @davidfestal https://github.com/davidfestal
- @flacatus https://github.com/flacatus
- @tinakurian https://github.com/tinakurian
- @mkuznyetsov https://github.com/mkuznyetsov
- @johnmcollier https://github.com/johnmcollier
- @elsony https://github.com/elsony
- @rkratky https://github.com/rkratky
- @jaideepr97 https://github.com/jaideepr97
- @mohammedzee1000 https://github.com/mohammedzee1000
- @SkorikSergey https://github.com/SkorikSergey
- @gorkem https://github.com/gorkem
- @maxandersen https://github.com/maxandersen
- @josephca https://github.com/josephca
- @yangcao77 https://github.com/yangcao77
- @scottkurz https://github.com/scottkurz
- @boczkowska https://github.com/boczkowska
- @wtam2018 https://github.com/wtam2018
- @mmulholl https://github.com/mmulholl
- @schultzp2020 https://github.com/schultzp2020
- @kadel https://github.com/kadel
- @amisevsk https://github.com/amisevsk
- @sleshchenko https://github.com/sleshchenko
- @l0rd https://github.com/l0rd
- @sbose78 https://github.com/sbose78
- @metlos https://github.com/metlos
- @maysunfaisal https://github.com/maysunfaisal
- @mmulholla https://github.com/mmulholla
- @ranakan19 https://github.com/ranakan19
- @benoitf https://github.com/benoitf
- @jc-berger https://github.com/jc-berger
- @mezarin https://github.com/mezarin
- @kim-tsao https://github.com/kim-tsao
- @EnriqueL8 https://github.com/EnriqueL8
- @themr0c https://github.com/themr0c
- @BethGriggs https://github.com/BethGriggs
- @ehsavoie https://github.com/ehsavoie
- @Nadianw36 https://github.com/Nadianw36
- @metacosm https://github.com/metacosm
- @pierreprinetti https://github.com/pierreprinetti
- @JPinkney https://github.com/JPinkney
- @Nwaid https://github.com/Nwaid
You can view, comment on, or merge this pull request online at:
https://github.com/devfile/api/pull/547 Commit Summary
- Change license to Apache 2.0
File Changes
- M LICENSE https://github.com/devfile/api/pull/547/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7 (478)
Patch Links:
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/devfile/api/pull/547, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTOHEOKX4S4YIVBVMBDPALTYVJTBANCNFSM5AVRRJYA .
I approve
I don’t know why I received the email, but I approve
I don’t know why I received the email, but I approve
@girishramnani maybe for this contribution https://github.com/devfile/library/pull/92?
I believe i had given my approval before, but since i don't see my name in the list of ones who have approved, here it is: I approve.
Regards, Kanika Rana
On Mon, Sep 13, 2021 at 7:00 AM Mario Loriedo @.***> wrote:
I don’t know why I received the email, but I approve
@girishramnani https://github.com/girishramnani maybe for this contribution devfile/library#92 https://github.com/devfile/library/pull/92??
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/devfile/api/pull/547#issuecomment-918077848, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEZUETLEJ2VUZIH35ZNYNDUBXKUFANCNFSM5AVRRJYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Best, Kanika
I believe i had given my approval before, but since i don't see my name in the list of ones who have approved, here it is: I approve. Regards, Kanika Rana
@ranakan19 I can see you checked in the list above. The only missing approval is @Nadianw36 (and @nwaid but I think that's the same user) but I wasn't able to reach her. Can someone help?
LGTM
@amisevsk thanks for #630
I got an approval from @Nadianw36, we are ready to merge now. We only need an approval on this PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: benoitf, l0rd, metacosm
The full list of commands accepted by this bot can be found here.
What does this PR do?
We are about to propose Devfile as a CNCF sandbox project. Most of the CNCF projects are licensed under Apache-2.0 and that’s what the community is used to. Re-licensing to Apache-2.0 would make the process smoother and augment our chances to successfully transition the project to CNCF sandbox. Both EPL-2.0 and Apache-2.0 are open source licenses that are widely used in the industry and Apache-2.0 is considered more permissive than EPL-2.0.
⚠️ This PR is in draft mode. We are contacting existing contributors to get their approval and then we will merge it.
What issues does this PR fix or reference?
https://github.com/devfile/api/issues/426
Contributors list (checked ones have approved the re-licensing)