Adds a timeout (500ms) to the health check HTTP client. This hopefully avoids cases where the controller effectively idles for long periods while the health check server is being started (i.e. the server is not ready and is not sending a response)
What issues does this PR fix or reference?
Haven't created an issue yet, need to do a bit more diagnosing.
Is it tested? How?
Also hard to test -- it's hard to trigger a slow response from the editor server manually. Regular workspace startup should not be impacted by this change, however.
PR Checklist
[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/devfile/devworkspace-operator/blob/main/OWNERS)~~ [amisevsk]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
What does this PR do?
Adds a timeout (500ms) to the health check HTTP client. This hopefully avoids cases where the controller effectively idles for long periods while the health check server is being started (i.e. the server is not ready and is not sending a response)
What issues does this PR fix or reference?
Haven't created an issue yet, need to do a bit more diagnosing.
Is it tested? How?
Also hard to test -- it's hard to trigger a slow response from the editor server manually. Regular workspace startup should not be impacted by this change, however.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che