Closed amisevsk closed 8 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: amisevsk, AObuchow
The full list of commands accepted by this bot can be found here.
The pull request process is described here
For some reason the check sources CI failed, the PR branch maybe wasn't based off of https://github.com/devfile/devworkspace-operator/pull/1180. Re-running it now
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c654384
) 52.96% compared to head (447af2e
) 53.01%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What does this PR do?
The
hub
CLI has been removed from the Ubuntu 20.04 runner and is intended to be replaced with the 'gh' CLI. This commit adapts the previous hub command to open a PR into a gh command that does the same.A note on arguments:
-f
(force, even if not all commits are pushed to remote) equivalent ingh
. This shouldn't be an issue because the prior command isgit push origin ${PR_BRANCH}
-f
ingh
means "create PR description from last commit", which should duplicate what the-m
was doing inhub
-b
(base branch) and-h
(head branch) are replaced with-B
and-H
What issues does this PR fix or reference?
release
GH action is failing.Is it tested? How?
I haven't directly tested, will probably have to wait for the next release to see if everything works appropriately.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che