devfile / devworkspace-operator

Apache License 2.0
59 stars 50 forks source link

Switch from using hub to gh in GitHub actions #1196

Closed amisevsk closed 8 months ago

amisevsk commented 8 months ago

What does this PR do?

The hub CLI has been removed from the Ubuntu 20.04 runner and is intended to be replaced with the 'gh' CLI. This commit adapts the previous hub command to open a PR into a gh command that does the same.

A note on arguments:

What issues does this PR fix or reference?

release GH action is failing.

Is it tested? How?

I haven't directly tested, will probably have to wait for the next release to see if everything works appropriately.

PR Checklist

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, AObuchow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/devfile/devworkspace-operator/blob/main/OWNERS)~~ [amisevsk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AObuchow commented 8 months ago

For some reason the check sources CI failed, the PR branch maybe wasn't based off of https://github.com/devfile/devworkspace-operator/pull/1180. Re-running it now

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c654384) 52.96% compared to head (447af2e) 53.01%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1196 +/- ## ========================================== + Coverage 52.96% 53.01% +0.05% ========================================== Files 84 84 Lines 7583 7583 ========================================== + Hits 4016 4020 +4 + Misses 3278 3275 -3 + Partials 289 288 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/devfile/devworkspace-operator/pull/1196/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=devfile)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.