Closed AObuchow closed 10 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
093bb40
) 52.82% compared to head (4d83873
) 52.84%.
Files | Patch % | Lines |
---|---|---|
controllers/workspace/devworkspace_controller.go | 0.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: amisevsk, AObuchow
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What does this PR do?
This PR makes 2 fixes to the $HOME persistence feature in DWO:
workspace.persistUserHome.enabled: true
field is set, and the workspace requires persistent storage (i.e. it uses the uses async, per-workspace or per-user storage strategy and has at least one-non ephemeral volume or has mount-sources enabled).persistentHome
->persistent-home
to be a valid Kubernetes name.(Sorry for putting 2 bug fixes in a single PR - it seemed to make sense since they're both related)
What issues does this PR fix or reference?
1200 & #1203
Is it tested? How?
Initial setup
export DWO_IMG=quay.io/<your-username>/devworkspace-controller:next
make install_cert_manager docker install
if testing on Minikube. For openshift, runmake docker install
kubectl edit dwoc -n $NAMESPACE
Testing fix for #1200
kubectl apply -f ./samples/plain.yaml
kubectl get dw -n $NAMESPACE -w
Testing fix for #1203
kubectl get dw -n $NAMESPACE -w
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che