fix: pin setup-envtest to v0.0.0-20240320141353-395cfc7486e6

AObuchow commented 3 months ago

What does this PR do?

Versions of envtest >= v0.0.0-20240322105421-affb96708000 require using go >= 1.22. As go 1.22 is only coming to Fedora 40 on April 16th 2024, we are pinning the version of env-test used for the DWO test suite to v0.0.0-20240320141353-395cfc7486e6 which requires go 1.20.

What issues does this PR fix or reference?

Fix https://github.com/devfile/devworkspace-operator/issues/1242

Is it tested? How?

For local testing, delete the /bin directory from the root of the repo and run make test. The required testing binaries (including setup-envtest) will be downloaded and the test suite should run successfully.

Also, ensure Check Sources GH action succeeds on this PR.

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
- [ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
- [ ] v8-che-happy-path: Happy path for verification integration with Che

AObuchow commented 3 months ago

The RH container registry is currently down so CI is unable to pull the base images required for docker builds.

AObuchow commented 3 months ago

/retest

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.52%. Comparing base (54f9871) to head (1d73597). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1243 +/- ## ======================================= Coverage 52.52% 52.52% ======================================= Files 84 84 Lines 7642 7642 ======================================= Hits 4014 4014 Misses 3335 3335 Partials 293 293 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/devfile/devworkspace-operator/blob/main/OWNERS)~~ [AObuchow,dkwon17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

devfile / devworkspace-operator