Closed dkwon17 closed 5 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Hello @AObuchow could you please take a look? I just want to make sure the code is OK before I add new tests
Attention: Patch coverage is 78.94737%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 52.84%. Comparing base (
adc8b5a
) to head (1a5164c
). Report is 26 commits behind head on main.:exclamation: Current head 1a5164c differs from pull request most recent head f83b0ba
Please upload reports for the commit f83b0ba to get more accurate results.
Files | Patch % | Lines |
---|---|---|
pkg/library/lifecycle/prestart.go | 50.00% | 3 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dkwon17 In the testing instructions, you said to grep for my-settings
instead of storageconf
: oc get pod <pod name> -o jsonpath='{.spec.containers[*].volumeMounts}' | grep my-settings
. Was that intentional?
@AObuchow sorry that was a mistake, it should be storageconf
@dkwon17 also before merging please squash your fixup commits & mention in the "Add test" commit that the tests are related to automount functionality with home persistence.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AObuchow, dkwon17, ibuziuk
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What does this PR do?
Disable automount resources for the
init-persistent-home
initcontainer (an not the other initcontainers) if persistent home is enabled.What issues does this PR fix or reference?
https://github.com/devfile/devworkspace-operator/issues/1257
Is it tested? How?
Deploy DWO:
In the DWOC named
devworkspace-operator-config
, enable persistent storage.Create a configmap that mounts to any directory:
Create a workspace and wait for it to start:
Verify that the first initcontainer is
init-persistent-home
, and that the configmap is mounted in all containers except forinit-persistent-home
:$ oc get pod -o jsonpath='{.spec.initContainers[0].volumeMounts}' | grep storageconf
// no match exists
$ oc get pod -o jsonpath='{.spec.initContainers[1].volumeMounts}' | grep storageconf
// match exists
$ oc get pod -o jsonpath='{.spec.initContainers[2].volumeMounts}' | grep storageconf
// match exists
$ oc get pod -o jsonpath='{.spec.containers[*].volumeMounts}' | grep storageconf
// match exists
sh-4.4$ cat ~/.stow.log | tail -n 10 LINK: go/pkg/mod/mvdan.cc/xurls/v2@v2.5.0/xurls_test.go => ../../../../../../../tooling/go/pkg/mod/mvdan.cc/xurls/v2@v2.5.0/xurls_test.go level of go/pkg/sumdb is 2 MKDIR: go/pkg/sumdb level of go/pkg/sumdb/sum.golang.org is 3 MKDIR: go/pkg/sumdb/sum.golang.org level of go/pkg/sumdb/sum.golang.org/latest is 4 LINK: go/pkg/sumdb/sum.golang.org/latest => ../../../../../tooling/go/pkg/sumdb/sum.golang.org/latest Planning stow of package .... done Processing tasks... Processing tasks... done