devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

Support devfile endpoint annotations in basic DevWorkspaceRouting solver #1296

Closed AObuchow closed 3 months ago

AObuchow commented 3 months ago

Description

This is a subtask of https://github.com/devfile/devworkspace-operator/issues/1023 and depends on https://github.com/devfile/devworkspace-operator/issues/1292.

The Devfile API defines .endpoints[].annotation - define annotations to be added to the route/ingress created for a specific endpoint.

The basic routing solver should support endpoint annotations, which will be applied to the created routes or ingresses associated with an endpoint.

Since the cluster-tls routing solver does not create endpoints, it doesn't make sense to implement this functionality there. However, we could potentially add these annotations to the workspace service created instead, as suggested in https://github.com/devfile/devworkspace-operator/issues/1023

Additional context

Related Che issue: https://github.com/eclipse-che/che/issues/23064