devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

Doc fix 1304 #1305

Closed mancubus77 closed 2 months ago

mancubus77 commented 3 months ago

Fixed #1304 Update links to API Reference

openshift-ci[bot] commented 3 months ago

Hi @mancubus77. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
AObuchow commented 3 months ago

@mancubus77 Thanks for catching this issue and for the PR. Could you please sign-off your commits? They are required for the DCO check to pass :)

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, mancubus77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/devfile/devworkspace-operator/blob/main/OWNERS)~~ [AObuchow] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AObuchow commented 3 months ago

/ok-to-test

openshift-ci[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

AObuchow commented 3 months ago

@mancubus77 The DCO check is still failing with:

Commit sha: 1fef901, Author: Mancubus, Committer: cerberus; Expected "Mancubus 16170560+mancubus77@users.noreply.github.com", but got "Ko Sta sk@redhat.com".

Checking your commit, it seems the author and committer are being recognized as different: image

You might have success resetting the author of your commit & setting your git email and name:

git config --global user.name "Correct Name" 
git config --global user.email name@email.com 
git commit --amend --reset-author

It also might be that your GitHub account's email is not your sk@redhat.com email? If the above doesn't work, I'll dig deeper into this. Sorry for the inconvenience.

AObuchow commented 2 months ago

@mancubus77 pinging you to make sure my earlier comment didn't get lost in your notifications :)

AObuchow commented 2 months ago

@mancubus77 any updates here? Alternatively, I'm happy to push to your fork and signoff the commit in order to resolve the DCO check

mancubus77 commented 2 months ago

👋 @AObuchow Yes please! Happy to have it under your name. Thank you, and apologies for the hassle.

AObuchow commented 2 months ago

@mancubus77 Sounds great thank you and no worries! I've updated your PR. It should be good to merge once the CI checks finish. Thank you again for your help here :)