Closed mancubus77 closed 2 months ago
Hi @mancubus77. Thanks for your PR.
I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@mancubus77 Thanks for catching this issue and for the PR. Could you please sign-off your commits? They are required for the DCO check to pass :)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AObuchow, mancubus77
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/ok-to-test
New changes are detected. LGTM label has been removed.
@mancubus77 The DCO check is still failing with:
Commit sha: 1fef901, Author: Mancubus, Committer: cerberus; Expected "Mancubus 16170560+mancubus77@users.noreply.github.com", but got "Ko Sta sk@redhat.com".
Checking your commit, it seems the author and committer are being recognized as different:
You might have success resetting the author of your commit & setting your git email and name:
git config --global user.name "Correct Name"
git config --global user.email name@email.com
git commit --amend --reset-author
It also might be that your GitHub account's email is not your sk@redhat.com email? If the above doesn't work, I'll dig deeper into this. Sorry for the inconvenience.
@mancubus77 pinging you to make sure my earlier comment didn't get lost in your notifications :)
@mancubus77 any updates here? Alternatively, I'm happy to push to your fork and signoff the commit in order to resolve the DCO check
👋 @AObuchow Yes please! Happy to have it under your name. Thank you, and apologies for the hassle.
@mancubus77 Sounds great thank you and no worries! I've updated your PR. It should be good to merge once the CI checks finish. Thank you again for your help here :)
Fixed #1304 Update links to API Reference