search

devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

Improve documentation for Webhook deployment configuration #1312

Closed AObuchow closed 2 months ago

AObuchow commented 2 months ago

What does this PR do?

What issues does this PR fix or reference?

Fix https://github.com/devfile/devworkspace-operator/issues/1289

Is it tested? How?

  1. Install DWO with the changes from this PR and login to your cluster with oc
  2. Do a kubectl explain dwoc.config.webhook. The DESCRIPTION field should show the new mentions of needing to use the global DWOC and restarting the devworkspace-controller-manager pod
  3. Check the additional docs (here's a link to them on my fork to easily view the changes)

PR Checklist

AObuchow commented 2 months ago

Oops my branch was branched off of https://github.com/devfile/devworkspace-operator/pull/1310 causing CI to fail. Will fix this quickly

dkwon17 commented 2 months ago

Thank you @AObuchow , I will merge soon

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/devfile/devworkspace-operator/blob/main/OWNERS)~~ [AObuchow,dkwon17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dkwon17 commented 2 months ago

I cannot merge because of a failing check: image

I am checking

AObuchow commented 2 months ago

CI is failing due to https://github.com/devfile/devworkspace-operator/issues/1314

openshift-ci[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.