chore: add note about ssh passphrase when mounting bashrc

devfile / devworkspace-operator

Apache License 2.0

67 stars 55 forks source link

chore: add note about ssh passphrase when mounting bashrc #1313

Closed dkwon17 closed 2 months ago

dkwon17 commented 2 months ago

What does this PR do?

Adds documentation about ssh passphrase when automounting bashrc with a configmap

What issues does this PR fix or reference?

https://github.com/devfile/devworkspace-operator/issues/1317

Is it tested? How?

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
- [ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
- [ ] v8-che-happy-path: Happy path for verification integration with Che

AObuchow commented 2 months ago

@dkwon17 thanks for the PR :) will review shortly

AObuchow commented 2 months ago

CI is failing due to https://github.com/devfile/devworkspace-operator/issues/1314

AObuchow commented 2 months ago

Now that https://github.com/devfile/devworkspace-operator/pull/1315 is merged, you should be good to rebase your PR onto main and the CI checks should pass @dkwon17 :)

AObuchow commented 2 months ago

@dkwon17 I quickly opened https://github.com/devfile/devworkspace-operator/issues/1317 so we can track this in the DWO 0.31.0 milestones :sunglasses:

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/devfile/devworkspace-operator/blob/main/OWNERS)~~ [AObuchow,dkwon17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment