devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

fix: temporarily pin goimports in GH Actions to v0.24.0 #1315

Closed AObuchow closed 2 months ago

AObuchow commented 2 months ago

What does this PR do?

The latest version of goimports (v0.25.0) requires go >= 1.22.0.

Since we are about to do the upstream release of DWO 0.31.0, we are temporarily pinning goimports to the last working version (v0.24.0).

After the 0.31.0 release of DWO, we can safely upgrade the entire repo to go 1.22.0, and use the latest version of goimports again.

What issues does this PR fix or reference?

Part of #1314 (initial, temporary fix)

Is it tested? How?

CI checks should pass (hopefully, if they run off my fork). I tested installing goimports@v0.25.0 and goimports@v0.24.0 in Che to see the required version of go for goimports v0.25.0:

projects $ go install golang.org/x/tools/cmd/goimports@latest
go: downloading golang.org/x/tools v0.25.0
go: golang.org/x/tools/cmd/goimports@latest: golang.org/x/tools@v0.25.0 requires go >= 1.22.0 (running go 1.21.11; GOTOOLCHAIN=local)
projects $ go install golang.org/x/tools/cmd/goimports@v0.24.0
go: downloading golang.org/x/mod v0.20.0
go: downloading golang.org/x/sync v0.8.0

Since the formating checks that install the latest version of goimports were succeeding last week , and goimports v0.25.0 was just released yesterday, I'm hopeful that this PR should work as expected to temporarily resolve #1314

PR Checklist

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/devfile/devworkspace-operator/blob/main/OWNERS)~~ [AObuchow,dkwon17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment