search

devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

Upgrade to go 1.22, unpin envtest and goimports #1316

Open AObuchow opened 2 months ago

AObuchow commented 2 months ago

We've had to pin envtest and goimports because we're currently using go 1.20 throughout the repo.

Originally, this was because go 1.22 was not available for the stable release of Fedora. Now, go 1.22 is available in Fedora 40 so we should finally upgrade the go version used throughout the repo.

AObuchow commented 2 months ago

Update: Unfortunately, it turns out we can't upgrade to go 1.22 yet because though it's available on Fedora (I'm running 1.22.5) it's not available yet for the go-toolset image we use in our Dockerfiles. The latest version of go-toolset goes up to go 1.21.11.

Since goimports v0.25.0 & latest envtest require go >= 1.22.0, for now we could at best only update to go 1.21.11. Both of these tools would have to remain pinned :(

AObuchow commented 1 day ago

This issue is now unblocked by https://github.com/devfile/devworkspace-operator/pull/1348!