search

devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

Remove caBundle from DevWorkspace and DevWorkspaceTemplate CRDs #1327

Closed dkwon17 closed 1 month ago

dkwon17 commented 1 month ago

Starting from Kubernetes 1.31.0 applying CRDs with invalid clientConfig.caBundle field cannot be reapplied: https://github.com/kubernetes/kubernetes/issues/125569#issuecomment-2261245120. This can prevent DWO installation.

This field is added by cert-manager with a valid caBundle, therefore the field and the dummy value can be removed. Example: https://github.com/devfile/devworkspace-operator/blob/533d1f0510b4dcfaee8682e5e0b8103812f79cfe/deploy/templates/cert-manager/crd_webhooks_patch.yaml#L20

Further discussion about caBundle: https://kubernetes.slack.com/archives/C0EG7JC6T/p1722442370023149?thread_ts=1722441161.968339&cid=C0EG7JC6T