devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

Add attribute to DWO-injected commands that should not be displayed to users #1333

Open AObuchow opened 1 month ago

AObuchow commented 1 month ago

Description

https://github.com/devfile/devworkspace-operator/pull/1307 & https://github.com/devfile/devworkspace-operator/pull/1329 added commands to devworkspaces with the name format init-ssh-agent-command-x. These commands are meant to be run automatically as postStart commands, rather than being invoked by users manually.

Currently, in Che we are [filtering out](https://github.com/che-incubator/che-code/pull/445 these specific commands in the editor so that they are not displayed in the commands list.

However, a better approach would be to add an attribute to all DWO-injected commands that should not be displayed to the user. For example, controller.devfile.io/internal-command: true.

Additional context

Thank you for the suggestion @RomanNikitenko :)