devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

Allow configuring memory and CPU requests / limits #1343

Open ibuziuk opened 3 weeks ago

ibuziuk commented 3 weeks ago

Description

Currently, it is not possible to configure memory and CPU for DWO pod. The only workaround is patching CSV directly, but since the CSV gets replaced as part of an upgrade, the modified value gets reverted to the older default values e.g. for devworkspace-controller-manager

              spec:
                containers:
                  - resources:
                      limits:
                        cpu: '3'
                        memory: 3Gi
                      requests:
                        cpu: 250m
                        memory: 100Mi

Additional context

Need to investigate if we can propagate RAM / CPU configuration from the subscription directly and if it is a good approach in general - https://developers.redhat.com/articles/2023/03/06/5-global-environment-variables-provided-openshift-gitops#

ibuziuk commented 3 weeks ago

@dkwon17 @AObuchow please, review