Closed vinokurig closed 2 weeks ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: vinokurig Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @vinokurig. Thanks for your PR.
I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@AObuchow sorry I did not see your pull request so I am closing mine in favour of yours.
@vinokurig No need to apologize, I appreciate you working on this :) Sounds good with me.
What does this PR do?
Wrap the
AddSshAgentPostStartEvent
function into theEnableExperimentalFeatures
condition.What issues does this PR fix or reference?
https://github.com/devfile/devworkspace-operator/issues/1337
Is it tested? How?
Create a workspace with a container without sh:
See: workspace starts successfully.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che