devfile / devworkspace-operator

Apache License 2.0
67 stars 55 forks source link

Mark the injection of the SSH agent postStart event as experimental feature #1344

Closed vinokurig closed 2 weeks ago

vinokurig commented 2 weeks ago

What does this PR do?

Wrap the AddSshAgentPostStartEvent function into the EnableExperimentalFeatures condition.

What issues does this PR fix or reference?

https://github.com/devfile/devworkspace-operator/issues/1337

Is it tested? How?

Create a workspace with a container without sh:

apiVersion: workspace.devfile.io/v1alpha2
kind: DevWorkspace
metadata:
  name: plain-devworkspace
spec:
  routingClass: che
  started: true
  template:
    components:
      - container:
          image: 'quay.io/devfile/universal-developer-image:ubi8-latest'
        name: universal-developer-image
      - container:
          image: 'ghcr.io/l0rd/outyet@sha256:3ab91b5801ab2e2a6147cab5d4a959838d9318921298e84cf7b6d19a3359e496'
        name: test

See: workspace starts successfully.

PR Checklist

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinokurig Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/devfile/devworkspace-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

Hi @vinokurig. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
vinokurig commented 2 weeks ago

@AObuchow sorry I did not see your pull request so I am closing mine in favour of yours.

AObuchow commented 2 weeks ago

@vinokurig No need to apologize, I appreciate you working on this :) Sounds good with me.