devfolioco / devfolio-gatsby-starter

Kickstart landing page development with GatsbyJS
MIT License
22 stars 94 forks source link

Fixed build error caused due to FAQ #3

Closed harshil1712 closed 5 years ago

ajayns commented 5 years ago

Hey @harshil1712 ! Thank you for the PR! I was thinking since we follow the convention of naming files in camelCase maybe we should rename FAQ.js to Faq.js. @apollonian opinions?

ajayns commented 5 years ago

Also, it'd be great if we can add this repo to netlify to see PR live previews @apollonian

apollonian commented 5 years ago

@ajayns Yep! That sounds good. @harshil1712 Can you rename the file please? Also, I'll turn the deploy previews on. ✌️

harshil1712 commented 5 years ago

@apollonian sure. I'll make the changes

ajayns commented 5 years ago

🎉

ajayns commented 5 years ago

Thank you @harshil1712 :)