devfolioco / react-otp-input

:heavy_check_mark: OTP Input Component for React

http://devfolioco.github.io/react-otp-input

MIT License

664 stars 426 forks source link

Placeholder Fixes #254

Closed Kathuria closed 3 years ago

Kathuria commented 3 years ago

255 - Updated condition for placeholder length with type check

and In demo added maxLength for placeholder as well.

What does this PR do? Fix Placeholder issue - placholder not updating value after change in input Number count.
Any background context you want to provide? https://github.com/devfolioco/react-otp-input/issues/255
Screenshots and/or Live Demo

apollonian commented 3 years ago

Thanks for reporting this. This could be an issue with the demo site and not the component. (Were you able to reproduce the issue in CodeSandbox demo) Further investing.

Kathuria commented 3 years ago

@apollonian : It will occur if provided inputNums count updated with string value. It won't be reproduced on Sandbox.

apollonian commented 3 years ago

👍 Yep, saw that as well. Pushing a fix..

apollonian commented 3 years ago

@Kathuria Pushed a fix for this since it was a critical one with https://github.com/devfolioco/react-otp-input/commit/93dfee48c6bfee6d95910d30c634ce3dfa350090.

Closing this PR out now 👀👏