fix: mobile autofill from native suggestion

devfolioco / react-otp-input

:heavy_check_mark: OTP Input Component for React

http://devfolioco.github.io/react-otp-input

MIT License

643 stars 423 forks source link

fix: mobile autofill from native suggestion #428

Closed hogiyogi597 closed 7 months ago

hogiyogi597 commented 8 months ago

What does this PR do? Provides a fix for mobile browsers to autofill codes directly from their native message notifications. This should resolve this issue as well: https://github.com/devfolioco/react-otp-input/issues/322
Any background context you want to provide? Pretty much just used @weiner-rakuten 's solution from this pull request but on the latest version.
Screenshots and/or Live Demo

iOS - iPhone 12 https://github.com/devfolioco/react-otp-input/assets/25204032/57081773-1a69-43f1-92cb-ca42165d1001

Android - Pixel 7 https://github.com/devfolioco/react-otp-input/assets/25204032/02eec490-e6a6-40e2-be98-6cf627eb59cc

hogiyogi597 commented 8 months ago

I'm not sure if this is the appropriate protocol to get reviewers so I apologize in advance but I wondered if @prateek3255 or @cesarvargas00 would be available in the next few days to give this one a look?

Thanks!

hogiyogi597 commented 7 months ago

Hello! Just wanting to bump this thread a bit. I know everyone is probably busy but I don't want these changes to get lost in the GitHub ether.

Tagging for visibility: @prateek3255 @cesarvargas00

beforeoafterm commented 7 months ago

Hello! Our team is also hoping this gets fixed. Any chance the maintainers can look into this PR?

mckaymichaelis commented 7 months ago

Also hoping for a fix for this 🤞

alexlibak commented 7 months ago

Same here, waiting for the fix 🙏🏼

hogiyogi597 commented 7 months ago

Hey, all! Still hoping to get this merged but need to fork the repo for now to get this issue resolved for us.

Please let me know how I can help get this merged here, thanks!

CC: @prateek3255 @apollonian

avtarvikas commented 7 months ago

@hogiyogi597 when will this be merged ? any idea ?

prateek3255 commented 7 months ago

Hey @hogiyogi597 Sorry for the delay here I might have missed the notification for the PR. I just have one question rest looks good

hogiyogi597 commented 7 months ago

@prateek3255 Thanks for looking it over! I responded to your question above. Let me know if there is any additional testing you'd like me to perform.

prateek3255 commented 7 months ago

Hey @hogiyogi597 I tested it on my end as well and isInputValid handles all the edge cases by itself anyways so we can get rid of maxLength. This is released with v3.1.1. Again thanks for your contribution and sorry for the dealy

prateek3255 commented 7 months ago

@all-contributors please add @hogiyogi597 for code

allcontributors[bot] commented 7 months ago

@prateek3255

I've put up a pull request to add @hogiyogi597! :tada:

alexlibak commented 7 months ago

Great work @hogiyogi597 ! Just updated it at my work's repository project and autofill works with ios 💪🏼