devgianlu / go-librespot

Yet another open source Spotify client, written in Go.
GNU General Public License v3.0
52 stars 7 forks source link

How to turn off any normalisation? #17

Closed phts closed 6 months ago

phts commented 6 months ago

https://github.com/devgianlu/go-librespot/blob/6e0c8b5c724acf2209a71039ab87c0cdd1b86a88/cmd/daemon/main.go#L282

If it is set to 0 in the config, it will be still reset to 1 and will affect output volume. Right? So how to turn it off completely?

devgianlu commented 6 months ago

I have improved the situation by not doing that with 9226eef548fb288c67fde22ba0254a95d051f428, if you set 0 then it'll be 0. However that does not disable normalization as the formula here is still applied:

https://github.com/devgianlu/go-librespot/blob/9226eef548fb288c67fde22ba0254a95d051f428/audio/metadata.go#L184-L192

phts commented 6 months ago

@devgianlu Please take a look at #18

devgianlu commented 6 months ago

By setting normalisation_disabled: true you should be good.

phts commented 6 months ago

@devgianlu and plz create new version

devgianlu commented 6 months ago

@devgianlu and plz create new version

Just finished running: https://github.com/devgianlu/go-librespot/releases/tag/v0.0.11