feat: option to disable normalization + change default pregain to 0

devgianlu / go-librespot

Yet another open source Spotify client, written in Go.

GNU General Public License v3.0

52 stars 7 forks source link

Closed phts closed 6 months ago

phts commented 6 months ago

Resolves #17

P.S. I didn't tested it due to lack of dev environment. Please take care of it.

devgianlu commented 6 months ago

I have addressed this with 1128433902507ccca4bde4e3b926abb7618308ce and 1ba777307956c53cecff51b46ea268b3e5f59ef3 for a couple of reasons:

Returning zero from GetTrackFactor would basically mute everything
I prefer not to pass something to GetTrackFactor just for it to return something, the caller can handle it.

Since this was a small matter I just did it myself, but thank you for the PR.