search

devgianlu / go-librespot

Yet another open source Spotify client, written in Go.
GNU General Public License v3.0
75 stars 15 forks source link

feat: add more fields into metadata response #9

Closed phts closed 11 months ago

phts commented 11 months ago

Related: #8

(not tested - because I dont have full dev environment, usually not a go dev)

devgianlu commented 11 months ago

Thank you for your contribution! I am not entirely sure whether the fields you are using will always be present on the track/episode, if they are not that may cause a nil dereference. Might require some testing.

phts commented 11 months ago

FYI according to API those fields for tracks are not nullable, so theoretically should always be present.

however for episode I cannot find number in API, but I took it from existing struct. For me episode data is not so important, so I can just stub them.