search

devgianlu / librespot-android

A demo app that runs librespot-java on Android
33 stars 13 forks source link

Use libtremolo: ARM-optimized implementation of VorbisCodec #1

Closed funtax closed 3 years ago

funtax commented 3 years ago

As Vorbis-/OGG-decoding via jorbis is a CPU-intensive job you might use the optimized version of libtremolo(NDK). It's used in my app since ~2016 and should work very stable.

devgianlu commented 3 years ago

@funtax I tried running the build, but it's complaining about ndk-build.cmd missing. Nevermind, I don't have NDK installed.

devgianlu commented 3 years ago

Having to depend on the entire librespot-player module isn't optimal. I should probably change it like I did for the sink, but it'd much more complicated. We'll see.

mitschwimmer commented 3 years ago

@devgianlu can you build tremolo now? I get an error while doing, seems to be the same as here: https://github.com/Suvitruf/Android-ndk/issues/3

devgianlu commented 3 years ago

@devgianlu can you build tremolo now? I get an error while doing, seems to be the same as here: https://github.com/Suvitruf/Android-ndk/issues/3

The PR comes with binaries already so I simply commented out the build command and it runs fine.

mitschwimmer commented 3 years ago

You seem me relieved :sweat_smile:

funtax commented 3 years ago

Hey there, i will try to give feedback on this later. Cannot see here if these tellOgg, readOgg etc. Have been removed, but they are required by the native parts.

devgianlu commented 3 years ago

I have noticed that after merging. I have added them back on master.