search

devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.
15 stars 8 forks source link

Artifacts in submission overview #304

Closed LiamClark closed 8 years ago

LiamClark commented 8 years ago

An example: TI1706 1516 - Software Quality & Testing (Group 10) Lopez Kü chlin on Wednesday 20 April 2016 15:49

instead of: Küchlin.

another: Daniël Daniël

Possibly some character encoding problems?, not urgent at all though so this one is for the backlog

jwgmeligmeyling commented 8 years ago

This should also appear in the commit list, or doesn't it? I expect it to come from the conversations between the git-server and de devhub-server.

LiamClark commented 8 years ago

Actually in the commit list it's allright

screen shot 2016-04-21 at 11 23 39

jwgmeligmeyling commented 8 years ago

Seems that it's not in the git-server indeed. Compare the two Freemarker templates:

From project-contributers.ftl (renders fine)

[#list repositoryEntity.getCollaborators() as member]
        <tr>
            <td>${member.getNetId()}</td>
            <td>${member.getName()}</td>
            <td><a href="mailto:${member.getEmail()}">${member.getEmail()}</a></td>
        </tr>
[/#list]

From assignment-view.ftl: (renders wrongly, also wrongly outputted HTML)

<div class="committer">${delivery.createdUser.getName()} on ${delivery.getTimestamp()?string["EEEE dd MMMM yyyy HH:mm"]}</div>