IssueTracker, fixes #148

[AZWN]

Implementing a basic issue tracker. Still in progress.

[jwgmeligmeyling]

Good start! Of all the introduced fields, I think they are best stored in AbstractIssue itself, even though Pull request do not currently support it, and changing pull requests may not be in the scope of this issue.

[AZWN]

Nice to hear :smile: What would you like as Issue specific features instead?

[jwgmeligmeyling]

I am looking for differences between Github issues and pull requests, and the only difference I seem to find is that one has code and the other doesn't :wink:

So maybe, until we have some good ideas, this class can just be empty! (But we do need it though!)

[coveralls]

Coverage decreased (-0.2%) to 56.81% when pulling f8a63d1794a8f1f73ad35da665ec0da38aa5ce05 on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[coveralls]

Coverage decreased (-0.1%) to 56.896% when pulling f8a63d1794a8f1f73ad35da665ec0da38aa5ce05 on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[jwgmeligmeyling]

👍 Tests pass again :)

[coveralls]

Coverage increased (+0.08%) to 57.127% when pulling 7a938f42683b8c050707fd605f637dd55ff65d0f on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[coveralls]

Coverage increased (+0.2%) to 57.214% when pulling c9aec644b881b3e0c7dbd651a7e6305ba7737f34 on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[jwgmeligmeyling]

👍

[coveralls]

Coverage decreased (-0.4%) to 56.603% when pulling 9e58b6eab86379ef503be387ccb580b44ee1c49b on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[jwgmeligmeyling]

Looks good so far! :+1:

[AZWN]

Whoops, it seems travis handles line breaks somewhat different

[coveralls]

Coverage increased (+0.8%) to 57.846% when pulling 038c9461975ec4378f63f5b71624fed78985d302 on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[jwgmeligmeyling]

I have almost no comments. Lets keep this as-is. You want me to look into adding the comments to the abstracted level and push the result to your branch, or do you see any further problems with that?

[jwgmeligmeyling]

What is the status of this branch? :wink: Still writing tests?

[AZWN]

Yes, indeed writing tests and fixing styling issues

[coveralls]

Coverage increased (+0.7%) to 57.778% when pulling f3d06c047e9a66cac7acfcdee96bc5ab87cb276b on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[AZWN]

Ok, I think this feature is quite ready now :smile:

[jwgmeligmeyling]

Great work! The IssueBackend seems to be not necessary right now, but as it is consistent with pull requests, I would keep it as is. I am going to spend this weekend merging PR's and redeploying I think. There is not a real need for changes, but have a look at my comments :wink:

[AZWN]

Haha thnx :) I've read your comments. Personally, I like to try and make things as good as possible. This week I don't have time left, but I would like to fix the small issues :D

[jwgmeligmeyling]

Ok I'll see whenever your changes arrive

[AZWN]

I've adressed some of the issues you pointed out.

[coveralls]

Coverage increased (+0.7%) to 57.728% when pulling 58285fa07c1869c065629c6dd9382ba81de753cc on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[jwgmeligmeyling]

Looks very promising on the first sight! Thanks for all the work. Will checkout the branch tonight.

[coveralls]

Coverage increased (+0.9%) to 57.984% when pulling 6d26f48277bf8497864b4ffa292a2364fe7c47cc on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.

[coveralls]

Coverage increased (+0.9%) to 57.984% when pulling 6d26f48277bf8497864b4ffa292a2364fe7c47cc on issue_tracker into d8f95cef7603f5a8bf1ab5630334d2ba3e18e1c9 on master.