Fixes #212, DeleteBranchesWithoutPR

[Fastjur]

Attempted to name branch using some standard conventions to see if GitHub picked this up correctly, unfortunately not. So will use descriptive branch names from now on.

This feature still needs testing

[coveralls]

Coverage decreased (-0.1%) to 56.854% when pulling 01de9b67c4448f316ef2ea2f78d7a93d47e90a8c on feature-212 into 546ac5710f069ffd304344a6a6a8976613d3e545 on master.

[coveralls]

Coverage decreased (-0.2%) to 56.768% when pulling 01de9b67c4448f316ef2ea2f78d7a93d47e90a8c on feature-212 into 546ac5710f069ffd304344a6a6a8976613d3e545 on master.

[jwgmeligmeyling]

Looks very good! 👍

[coveralls]

Coverage decreased (-0.1%) to 56.824% when pulling a3c119f6d706387265465cf1b3e36dfeae6e9904 on feature-212 into 546ac5710f069ffd304344a6a6a8976613d3e545 on master.

[jwgmeligmeyling]

Added one commit to your branch to change the type of branchDeletion to be a Boolean. The other changes don't really have to be implemented I suppose. I think we can merge this. Perhaps it will be good (if not to difficult) to add a test case for it as well.

Students quite often request to be able to remove ahead branches as well. Maybe we should also think how we want users to be able to do that. Maybe we should allow for any branch other than refs/heads/master to be removed through the Git CLI, and not implement this in Devhub UI.

[Fastjur]

Yes I heard many complaints about 'ahead' branches as well. My idea was to just get this one out quickly, as this removes most peoples problems. And then build a simple change on top of it for ahead branches.

I personally had the idea to show a popup, asking the user to type the branchname in as conformation, to prevent accidental removal of ahead branches, and then a big red warning in this popup.

[coveralls]

Coverage decreased (-0.1%) to 56.808% when pulling aa8013229865c6ce0fac7238c4d30b47750f448a on feature-212 into 546ac5710f069ffd304344a6a6a8976613d3e545 on master.

[jwgmeligmeyling]

Are you still working on this branch by the way, or is it ready to be merged?

[Fastjur]

It can be merged, I will ask you somethings during the next seminar about the git-server. Then I can implement the tests.

[coveralls]

Coverage decreased (-0.1%) to 56.808% when pulling 729d250da3bb5b66a9104c53ee1aacb76fe89b26 on feature-212 into 31179e31587c49f1e6b5b7a93d14895d714055d9 on master.

[coveralls]

Coverage decreased (-0.1%) to 56.808% when pulling 729d250da3bb5b66a9104c53ee1aacb76fe89b26 on feature-212 into 31179e31587c49f1e6b5b7a93d14895d714055d9 on master.

[Fastjur]

Ready to merge, tests will be implemented after next seminar

[jwgmeligmeyling]

Thanks! :+1: