search

devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.
15 stars 8 forks source link

Emojis, fixes #322 #399

Closed jwgmeligmeyling closed 8 years ago

jwgmeligmeyling commented 8 years ago

Replaces #392

jwgmeligmeyling commented 8 years ago

@Fastjur Can you rebase your emojis branch on the current MarkDownRendering branch? It seems you have duplicated @DouweKoopmans commits. They need to be removed from this PR, and the merge conflicts should be resolved.

Fastjur commented 8 years ago

Hmm this is weird, I checked out from that branch, that is why the commits are in this one most likely. However when rebasing emojis onto MarkdownRendering I lose all the changes from emojis. Git plz...

Fastjur commented 8 years ago

Hmm this is so weird...

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.7%) to 57.644% when pulling 71ecf2c32981cd38da1a53b74b3e6394fb86761d on emojis into d4883e51608cb871277f19c4408d6eef634bc346 on MarkdownRendering.

jwgmeligmeyling commented 8 years ago

Rebased on emojis. We still need to do some tricks client side so the emojis display everywhere. Perhaps we should also include some kind of list of possible emojis, or link to a page that has them listed?

Fastjur commented 8 years ago

We still need to do some tricks client side so the emojis display everywhere.

This has been added in the last commits. The emojis are now universal (img tags).

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.6%) to 57.558% when pulling 23db800dde6799f816770850dbc12c92b66f26fb on emojis into d4883e51608cb871277f19c4408d6eef634bc346 on MarkdownRendering.

jwgmeligmeyling commented 8 years ago

Will checkout later today :smile: Thanks!

Fastjur commented 8 years ago

Added the emoji hinting when typing. Ready to merge

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.7%) to 57.644% when pulling c1d7b81e7f009ca54845ab1f2358b4e45ef8c601 on emojis into d4883e51608cb871277f19c4408d6eef634bc346 on MarkdownRendering.

TimvdLippe commented 7 years ago

This PR introduces a new dependency twemoji which accounts for 0.5GB of the total 1GB of the whole repository. Was there any comparison between different implementations to support emojis? Seems like a very big hit for such a small change :O