search

devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.
15 stars 8 forks source link

Using chrome instead of firefox for webdriver. #413

Closed avandeursen closed 8 years ago

avandeursen commented 8 years ago

Firefox 47 does not play well with webdriver 2.53: http://stackoverflow.com/questions/37693106/selenium-2-53-not-working-on-firefox-47

Switched to chrome instead of downgrading my firefox to 46. (you may have to (brew) install chromedriver)

For me two tests fail at the moment, both related to setting the state in the DeliveryReviewView.

AssignmentReviewTest.testReviewForm:64 » NoSuchElement No value present AssignmentReviewTest.testSubmitReview:79 » NoSuchElement No value present

avandeursen commented 8 years ago

And we should update the .travis.yml to download chromedriver too.

avandeursen commented 8 years ago

The two tests failing for chrome have been fixed in #414, and now work for FF and Chrome.

avandeursen commented 8 years ago

Getting travis to use chrome maybe a bit more involved than I thought.

And the tests work well with Firefox 46, so I propose to close this PR for now.

jwgmeligmeyling commented 8 years ago

Seems a bit complicated indeed. Linking to the related issue on the Travis tracker: https://github.com/travis-ci/travis-ci/issues/272#issuecomment-194370288 . Lets not remove the branch for future reference, maybe some developers want to use it in their personal configuration.