devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.
15 stars 8 forks source link

Cleanup of the LargeCommitWarningGenerator #422

Closed LiamClark closed 7 years ago

LiamClark commented 7 years ago

This pr addresses some minimal technical debt:

Drop mutable extension field, simply pass the parameter down. Removal of an unnecessary @SneakyThrows.

Rewrote a filter().findAny().isPresent() to the more intention revealing any match method.

Removed unnecessary cast from long to int.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 56.169% when pulling bddbf653283d82f114d7cab52d0c813204d990f3 on LiamClark:large-commit-warning-generator-clean-up into b5abb8a03cd7e0eb3f162c6df0c0f38599a83b3c on devhub-tud:master.