search

devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.
15 stars 8 forks source link

Fix the webtests by upgrading Selenium #427

Closed TimvdLippe closed 7 years ago

TimvdLippe commented 7 years ago

The webtests were not running anymore, as the Selenium drivers were not compatible with the latest versions of Firefox. Therefore, the fix is to upgrade Selenium to 3.x and use the Chrome driver instead of the Firefox driver.

I have added build instructions to the CONTRIBUTING.md and migrated the webtests code. Note that we can not rely on Selenium 3.3.1, as that has a dependency on Guava:21.0 which is incompatible with most of the other code (other devhub dependencies as well as querydsl).

Let's see if this thing passes on CI.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.08%) to 55.843% when pulling b9672bb5c6cdf124a478d1482f797b782d9636d0 on TimvdLippe:fix-webtests into 448e1411be2431a3be055913b504b029386af00d on devhub-tud:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.08%) to 55.843% when pulling b9672bb5c6cdf124a478d1482f797b782d9636d0 on TimvdLippe:fix-webtests into 448e1411be2431a3be055913b504b029386af00d on devhub-tud:master.

TimvdLippe commented 7 years ago

@LiamClark done!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.08%) to 55.843% when pulling 8f0c64d5a325fea0a41bd1e495a53657330fa58e on TimvdLippe:fix-webtests into 448e1411be2431a3be055913b504b029386af00d on devhub-tud:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 55.918% when pulling 384a6d8ed6e10b533b310473f0db140caeb9e67a on TimvdLippe:fix-webtests into 448e1411be2431a3be055913b504b029386af00d on devhub-tud:master.