devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.
15 stars 8 forks source link

Display the amount of warnings and errors in a commit or part #462

Closed mjwsteenbergen closed 7 years ago

Fastjur commented 7 years ago

What warnings and errors would you want to see?

jwgmeligmeyling commented 7 years ago

We do display this but warnings were disabled until today.

mjwsteenbergen commented 7 years ago

I thought that the warnings displayed next to the commit were the new warnings generated. This is not the case, so I will close the issue.

jwgmeligmeyling commented 7 years ago

They do appear on the commit where the warning was generated if the line was introduced in that commit. If the line was introduced in an older commit, you should retroactively rebuild that commit. The count only shows "introduced" warnings. A disadvantage of enabling warnings relatively late, is that old warnings don't appear in the diff too. But they were enabled straight after part 1, so for entire part 2 it should be good.