search

devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.
15 stars 8 forks source link

Compute state and grade on review if rubrics and grading strategy is used #469

Closed jwgmeligmeyling closed 7 years ago

jwgmeligmeyling commented 7 years ago

This PR disables the grade and submission state inputs for TA's whenever a grading strategy is in place combined with any rubrics. Instead these fields are now generated right after finishing the review.

We currently do not update the grade when there is any change to the rubrics (for example the weights, or adding a new rubric). When the grades are released (or re-released), the grades will be re-computed. We may want to change the workflow here as this may be surprising. Recomputing the existing grades and statusses whenever the rubrics are changed probably makes more sense, and would make our "release and compute all" logic unnecessary.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.08%) to 56.15% when pulling 181aa0dc4fb8b29434c9cd3a662cd3df13463dc9 on JWGmeligMeyling:set-status-grade-on-review into b9badfc81b2bd5ba905ed71268de6d1907e7705a on devhub-tud:master.