devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.
15 stars 8 forks source link

Show line changes, fixes #218, fixes #233 #473

Closed herfstregen closed 7 years ago

jwgmeligmeyling commented 7 years ago

Changes look good! Try to pay a bit more attention to your git commit headers. Try to be descriptive and stick to project conventions (such as using english commit headers). You have one shot, It'll be in the repository forever, get it right :wink: Also, you seem to sometimes merge each others changes in. By convention, if you're working together on the same feature or branch, it is usually preferred to rebase instead of merge so that you do not get multiple merge commits within your branch. No need to fix any of these , just keep it in mind!

pilmus commented 7 years ago

Very nitpicky, but I think it'd look nice if the lines were drawn through the red and green parts.

nitpick

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 56.041% when pulling 0a6146c31b7e9f5f528dbfe7ef4cc694fed5a87a on showLineChanges into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 56.041% when pulling 1e85610e14ff00c26006c7d0d9e49757ee0bcb92 on showLineChanges into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

asylunatic commented 7 years ago

😢

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 56.041% when pulling 7f840600911cbbb035533d08199b3e66a24b6c26 on showLineChanges into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 56.024% when pulling d42ddb52ef3d4da300e9227e915b7c07bcbb73b3 on showLineChanges into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.