Assign groups to be graded to TA's, fixes #397 (work in progress) - Githubissues

devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.

15 stars 8 forks source link

Assign groups to be graded to TA's, fixes #397 (work in progress) #475

Closed jwgmeligmeyling closed 7 years ago

jwgmeligmeyling commented 7 years ago

Work in progress, opened PR for code review.

TimvdLippe commented 7 years ago

You can more easily review this PR with https://github.com/devhub-tud/devhub/pull/475/files?w=1 (note the ?w=1 appended to the url)

Fastjur commented 7 years ago

Man I wish my PRs were so full of discussion when I was doing the star module...

TimvdLippe commented 7 years ago

Oh and one more enhancement, which is probably not a strict requirement, is to assign a TA to a group iff that TA did not grade that group already for a previous assignment. Not sure how complicated that enhancement would be. Our current gist does not take this into account, so we can live without it :P

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 55.854% when pulling 93a5a0684902eebfb9ed249153750d7d6ad03ea4 on assignedGrading into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

coveralls commented 7 years ago

Coverage increased (+1.6%) to 57.801% when pulling 93a5a0684902eebfb9ed249153750d7d6ad03ea4 on assignedGrading into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 56.001% when pulling 752a5bafdfe4b766f1ec4347477576a91d9d85c0 on assignedGrading into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 56.001% when pulling e35683308d9be61f2c2b4c1d95898b45e162abae on assignedGrading into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

coveralls commented 7 years ago

Coverage increased (+1.2%) to 57.261% when pulling 51ef30d3ac58ac04bc9a433c031a1b512d06bb15 on assignedGrading into a27fe79c2064f525a333e78cb4b2579c7d16787e on master.

coveralls commented 7 years ago

Coverage increased (+1.1%) to 57.166% when pulling ff13250fe33588b71573b0a1d66c33bba9b25078 on assignedGrading into a27fe79c2064f525a333e78cb4b2579c7d16787e on master.

coveralls commented 7 years ago

Coverage increased (+1.2%) to 57.224% when pulling 5318291fae0e7813279d59de2159f038fc13c375 on assignedGrading into a27fe79c2064f525a333e78cb4b2579c7d16787e on master.

coveralls commented 7 years ago

Coverage increased (+1.2%) to 57.224% when pulling 1190744d2a5b38ade255469b7dbd8cc538e3033f on assignedGrading into a27fe79c2064f525a333e78cb4b2579c7d16787e on master.

coveralls commented 7 years ago

Coverage increased (+1.2%) to 57.224% when pulling 1190744d2a5b38ade255469b7dbd8cc538e3033f on assignedGrading into a27fe79c2064f525a333e78cb4b2579c7d16787e on master.