Notifications database (WIP), fixes #394 , fixes #324

devhub-tud / devhub

DevHub is a software system designed to give students a simple practical introduction into modern software development.

15 stars 8 forks source link

Notifications database (WIP), fixes #394 , fixes #324 #479

Closed ArjanSeijs closed 7 years ago

ArjanSeijs commented 7 years ago

Added a database for notifications
Added a database to assign notifications to multiple users with a hasRead field.
Added a page where the notifications can be shown + a indicator when there are unread notifications.
Notifications can be mark as read.
Todo: The notifications need to be displayed on the notifications page.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 56.014% when pulling 382325087b74ffaff3d0b43b37b347fda6da90e8 on NotificationsDatabase into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

coveralls commented 7 years ago

Coverage decreased (-0.5%) to 55.719% when pulling fa9e375cdd21d6a610f497014e9df5d604675a61 on NotificationsDatabase into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

ArjanSeijs commented 7 years ago

@TimvdLippe It was a placeholder icon, we already changed it to a number indicator to show how many unread notifications it has. I already removed the image.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 55.937% when pulling 64ec045be3cd5a40f8cc13f02420f182f9d709f2 on NotificationsDatabase into b9badfc81b2bd5ba905ed71268de6d1907e7705a on master.

coveralls commented 7 years ago

Coverage decreased (-0.06%) to 55.968% when pulling b92925801ad1dabf5324a2d3e9b13133d287b9ac on NotificationsDatabase into a27fe79c2064f525a333e78cb4b2579c7d16787e on master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 56.498% when pulling ef4a592a47cd13c478b0ab1b030252d4ec8eeac6 on NotificationsDatabase into a27fe79c2064f525a333e78cb4b2579c7d16787e on master.

pilmus commented 7 years ago

Could you guys add a way to remove notifications after you've read them?

Fastjur commented 7 years ago

This is starting to become a bit of a clusterfuck of a PR.

Perhaps splitting it up would be a good idea?

coveralls commented 7 years ago

Coverage increased (+0.9%) to 58.013% when pulling fe6aa718999b776cd229b228d82298bb425d836c on NotificationsDatabase into 29e9043130a1be1ed9ddec09a37212420ffd1cee on master.

jwgmeligmeyling commented 7 years ago

I have pushed some changes that change how we resolve the URI of the warning. I've also refactored how we create the notifications so it requires slightly less boilerplate.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 57.203% when pulling 2e2b70393975126c94cba70a84d4a07dc0c6c273 on NotificationsDatabase into 29e9043130a1be1ed9ddec09a37212420ffd1cee on master.

coveralls commented 7 years ago

Coverage increased (+0.02%) to 57.088% when pulling 2781ddfaf8d184eb6768c796df65a91384028860 on NotificationsDatabase into 29e9043130a1be1ed9ddec09a37212420ffd1cee on master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 57.593% when pulling f4b8e8ac1bfdfb1cec3bf53addc3e8af9b200d3d on NotificationsDatabase into 29e9043130a1be1ed9ddec09a37212420ffd1cee on master.

coveralls commented 7 years ago

Changes Unknown when pulling 79f88c2cb1936c1b6b649574b6f7e165548cf91e on NotificationsDatabase into on master.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 57.025% when pulling 79f88c2cb1936c1b6b649574b6f7e165548cf91e on NotificationsDatabase into c107c37159dc7afbfbb6629f644dff8856243abf on master.