search

devhyper / open-video-editor

Open source Android video editor, built with Media3 and Jetpack Compose.
GNU General Public License v3.0
289 stars 12 forks source link

[Feature] Need for a more intuitive UI for cropping #2

Closed adarsh1001 closed 4 months ago

adarsh1001 commented 6 months ago

First up, thanks for creating this project! There is a dearth of open source video editors and afaik this is the first one 🥳

This issue is about enhancing the UI for video cropping. Currently, the app requires us to manually input the output height and width which is tedious because we don't know that most of the time: Screenshot_20240101-102604.png

Instead, would be great if we can have something like what Simple Gallery's proprietary video editor does. Basically, allow the user to draw the rectangle over the video and take height and width from it. We can have both manual input and this rectangle UI if need be. https://github.com/devhyper/open-video-editor/assets/8820038/e59d271c-e239-46cf-852f-a43934a56aef

As mentioned before, Simple Gallery's video editor is proprietary, although they publish it on GitHub (link). But it's an excellent tool for the job and quite intuitive to use. As a first step, maybe the goal can be to at least cover the features here and take cues from the UI.

Cwpute commented 6 months ago

Showing the original resolution would also greatly help if you don't know the video resolution beforehand.

adarsh1001 commented 4 months ago

@devhyper Crop isn't working correctly for landscape videos. Example:

https://github.com/devhyper/open-video-editor/assets/8820038/2539b637-9170-433e-9242-df4a3afd99e1