search

devianl2 / laravel-scorm

Laravel scorm package
MIT License
38 stars 20 forks source link

Enhances from my working version. #21

Closed KhaledLela closed 1 year ago

KhaledLela commented 1 year ago
devianl2 commented 1 year ago

Hi @KhaledLela,

Your contribution is highly appreciated. I've gone through your code at commit [f3da307](https://github.com/devianl2/laravel-scorm/pull/21/commits/04fc94e0157136e6ce04c3d20edbf2845c4e0ebe), do you think is essential to store CMI data in createScoTracking() function?

My concern is the user has the flexibility to update their profile information in their own LMS. At the moment I generate CMI data from application controller instead of package itself so that programmer has more control over CMI data customization. What do you think?