search

devianl2 / laravel-scorm

Laravel scorm package
MIT License
38 stars 20 forks source link

Fix: Move the deleteScormFolder() method call to the deleteScorm() me… #28

Open Kreshnik opened 1 year ago

Kreshnik commented 1 year ago

When calling the method

public function uploadScormArchive(UploadedFile $file, $uuid = null)

It calls within it the method:

private function saveScorm($file, $filename, $uuid = null)

Which calls the method:

private function generateScorm($file)

Which calls the unzipper method on the scormDisk object. The scorm path is cleared within the method body before the new content is made available.

As deleteScormData is called further down in the uploadScormArchive method, all content is removed after a successful upload.

Kreshnik commented 1 year ago

@devianl2 can someone do a pull?