deviantfero
commented
2 years ago I'll take a look later today, yeah I've been a bit busy so thanks for the PR
On Sun, Jul 24, 2022, 12:46 AM Gnik @.***> wrote:
Fixes #158 https://github.com/deviantfero/wpgtk/issues/158 .
Since it seems you are busy, I have fixed the dunst reload issue. I have been using this version on Arch for a long time now without any problems.
This does mean that any dunst instances running from a custom configuration file will not be reloaded properly. Until the dunst maintainers add the option to send a signal to reload, this is the best we can do.
You can view, comment on, or merge this pull request online at:
https://github.com/deviantfero/wpgtk/pull/262 Commit Summary
- ef7f59a https://github.com/deviantfero/wpgtk/pull/262/commits/ef7f59aa5d16d79c1c3052bf83af5ec87c73d21d Restart dunst on reload
File Changes
(1 file https://github.com/deviantfero/wpgtk/pull/262/files)
- M wpgtk/data/reload.py https://github.com/deviantfero/wpgtk/pull/262/files#diff-7ef972a14132a786181a6c85620bd45759e1acccf4a8454426f0a7319ac0f543 (3)
Patch Links:
- https://github.com/deviantfero/wpgtk/pull/262.patch
- https://github.com/deviantfero/wpgtk/pull/262.diff
— Reply to this email directly, view it on GitHub https://github.com/deviantfero/wpgtk/pull/262, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCGSJG6UTNGNJWHSX775LVVTRC3ANCNFSM54PFNCZA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Fixes #158 .
Since it seems you are busy, I have fixed the dunst reload issue. I have been using this version on Arch for a long time now without any problems.
This does mean that any dunst instances running from a custom configuration file will not be reloaded properly. Until the dunst maintainers add the option to send a signal to reload, this is the best we can do.