search

deviantfero / wpgtk

:flower_playing_cards: a colorscheme, wallpaper and template manager for *nix
http://deviantfero.github.io/wpgtk/
GNU General Public License v2.0
2.06k stars 48 forks source link

Add support for pywal16cols, fix pywal16cols api diff #296

Closed BoolmanO closed 6 months ago

BoolmanO commented 10 months ago

The problem is in different "wal" functions API.

pywal16cols

def cache_fname(img, backend, cols16, light, cache_dir, sat=""):

standard pywal

def cache_fname(img, backend, light, cache_dir, sat=""):
eylles commented 6 months ago

optionally you could check for version, regular pywal will never move beyond 3.3.0.

BoolmanO commented 6 months ago

optionally you could check for version, regular pywal will never move beyond 3.3.0.

Yeah, quite a few repos have been archived lately, which is pretty sad. Of course, the check version function is open to any changes, you can speed it up as you like, but so far the pull request has not been accepted. Thanks for the comment, thanks to it I found out that pywal is archived :(

deviantfero commented 6 months ago

if pywal is archived I will take a closer look at this PR, I'm primarily an arch user but I'd like for pywal16-colors to be available in official repos before merging this

eylles commented 6 months ago

pywal16 is on both pypi and the aur, recently i added an action to automatically upload on releases.

https://repology.org/project/pywal16/versions

BoolmanO commented 6 months ago

if pywal is archived I will take a closer look at this PR, I'm primarily an arch user but I'd like for pywal16-colors to be available in official repos before merging this

the code does not break if the user just has pywal. Pywal16cols has been in the aur for a long time

BoolmanO commented 6 months ago

@eylles why the command wal -v output to stderr?

[EDIT] damn, pywal writes to stderr too... well I hope you don't change that

BoolmanO commented 6 months ago

looks fine now and ready to merge

eylles commented 6 months ago

@eylles why the command wal -v output to stderr?

[EDIT] damn, pywal writes to stderr too... well I hope you don't change that

Ah the "great" things dylan did on pywal, don't worry that won't change on pywal16 as it is intended to be a continuation so i really cannot change out facing behaviour no matter how bad it may be because that is what the og pywal had and some project out there expects that "bad" behaviour...

What i can do change is internals of functiobs to optimize them, tho how some things work with the internals of pywal may as well be duct tape and hope...

deviantfero commented 6 months ago

All of this sounds good to me, I'll go ahead and merge, ill update the package release soon

vaskark commented 1 month ago

Is pywal16 working in wpgtk for people yet?

eylles commented 1 month ago

perchance

deviantfero commented 1 month ago

I will look into this over the weekend

On Sat, Oct 5, 2024, 5:54 PM vaskark @.***> wrote:

Is pywal16 working in wpgtk for people yet?

— Reply to this email directly, view it on GitHub https://github.com/deviantfero/wpgtk/pull/296#issuecomment-2395229674, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCGSOVWO6UWYLO25XHVEDZ2B33FAVCNFSM6AAAAABBRS5KC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGIZDSNRXGQ . You are receiving this because you modified the open/close state.Message ID: @.***>