search

deviantintegral / drupal_tests

A docker container based for running Drupal tests in CircleCI
GNU General Public License v3.0
24 stars 9 forks source link

phpunit and phpcs missing from jobs now #63

Open davereid opened 4 years ago

davereid commented 4 years ago

As of Drupal 8.8.0, the dev dependencies have gone missing from CircleCI update-dependencies jobs. We may need to add drupal/core-dev to our required modules?

davereid commented 4 years ago

I'm attempting to add drupal/core-dev to an existing job's composer.json:

root@8e5854c36240:/var/www/html# composer require drupal/core-dev:^8.8.0
    1/1:        http://repo.packagist.org/p/provider-latest$e58c34729987a6eaa368aa8f740ddcbebe18ff46347beffcf2b39ce013a3d56b.json
    Finished: success: 1, skipped: 0, failure: 0, total: 1
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Installation request for drupal/core-dev ^8.8.0 -> satisfiable by drupal/core-dev[8.8.0].
- drupal/core-dev 8.8.0 requires behat/mink 1.8.0 | 1.7.1.1 | 1.7.x-dev -> satisfiable by behat/mink[1.7.x-dev] but these conflict with your requirements or minimum-stability.

Installation failed, reverting ./composer.json to its original content.
davereid commented 4 years ago

It looks like in our root composer.json:

    "minimum-stability": "stable",
    "prefer-stable": true,

Seems like minimum-stability should be dev...

davereid commented 4 years ago

Updating minimum-stability to dev, and then requiring drupal/core-dev:^8.8.0 installs the necessary tools we need.

davereid commented 4 years ago

Confused, because we should be using quay.io/deviantintegral/drupal_tests:0.5.0-drupal87, but for some reason we're ending up with Drupal 8.8.0. I see the docker image was updated a day ago, presumably for the new core release. I could use help resolving this for Drupal 8.8.0. :/

davereid commented 4 years ago

More debugging, wikimedia/merge-plugin is also gone by default, so it was not merging in our repo module's composer.json file at all.

davereid commented 4 years ago

Adding this above the call to ./update-dependencies.sh in our config.yml seemed to resolve it:

        command: |
          composer config minimum-stability dev
          composer config platform.php 7.3
          composer require wikimedia/composer-merge-plugin zaporylie/composer-drupal-optimizations drupal/core-dev
          ./update-dependencies.sh $CIRCLE_PROJECT_REPONAME