search

device-automation-bus / dab-adapter-rs

Apache License 2.0
2 stars 8 forks source link

feat: updating hdmicec plugin configuration #64 #65

Closed kvfasil closed 3 months ago

kvfasil commented 3 months ago

HdmiCec_2 plugin has been deprecated in rdkv stack. and replaced by the HdmiCecSource plugin HdmiCecSource will not be enabled by default.

kvfasil commented 3 months ago

settings related cec api's verified.

`` python3 main.py -v -b ${DEVICE_IP} -I ${DEVICE_ID} -c SystemSettingsListConformance

testing system/settings/list {} ... system/settings/list Latency, Expected: 200 ms, Actual: 135 ms

[ PASS ] { "audioOutputMode": [ "Stereo", "MultichannelPcm", "PassThrough", "Auto" ], "audioOutputSource": [ "HDMI", "Optical" ], "audioVolume": { "max": 100, "min": 0 }, "cec": true, "hdrOutputMode": [ "DisableHdr" ], "language": [ "en-US" ], "lowLatencyMode": false, "matchContentFrameRate": [ "EnabledAlways" ], "memc": false, "mute": true, "outputResolution": [ { "frequency": 50.0, "height": 576, "width": 720 }, { "frequency": 30.0, "height": 1080, "width": 1920 }, { "frequency": 30.0, "height": 2160, "width": 3840 }, { "frequency": 50.0, "height": 1080, "width": 1920 }, { "frequency": 50.0, "height": 2160, "width": 3840 }, { "frequency": 60.0, "height": 1080, "width": 1920 }, { "frequency": 60.0, "height": 2160, "width": 3840 } ], "pictureMode": [], "status": 200, "textToSpeech": false, "videoInputSource": [ "Home" ] }``

kvfasil commented 3 months ago

python3 main.py -v -b ${DEVICE_IP} -I ${DEVICE_ID} -c SystemSettingsGetConformance

testing system/settings/get {} ... system/settings/get Latency, Expected: 200 ms, Actual: 851 ms

system/settings/get took more time than expected.

[ FAILED ] { "audioOutputMode": "Auto", "audioOutputSource": "HDMI", "audioVolume": 100, "cec": false, "hdrOutputMode": "DisableHdr", "language": "en-US", "lowLatencyMode": false, "matchContentFrameRate": "EnabledAlways", "memc": false, "mute": false, "outputResolution": { "frequency": 59.94, "height": 2160, "width": 3840 }, "pictureMode": "Standard", "status": 200, "textToSpeech": false, "videoInputSource": "Home" }

kvfasil commented 3 months ago

python3 main.py -v -b ${DEVICE_IP} -I ${DEVICE_ID} -c SystemSettingsSetCec

testing system/settings/set {"cec": true} ... system/settings/set Latency, Expected: 3000 ms, Actual: 392 ms

[ PASS ] { "status": 200 }

arun-madhavan-013 commented 3 months ago

Hi @kvfasil ,

HdmiCec_2 plugin has been deprecated in rdkv stack. and replaced by the HdmiCecSource plugin HdmiCecSource will not be enabled by default.

These changes are not yet available to community since its part of HEAD of RDKV stack. I would suggest to use https://github.com/device-automation-bus/dab-adapter-rs/tree/v0.7.0 branch for upcoming RDKV changes.

Hi @denisyuji , We will use https://github.com/device-automation-bus/dab-adapter-rs/tree/v0.7.0 to align with internal RDKV changes until it gets released to community. Hope that is fine.

denisyuji commented 3 months ago

@arun-madhavan-013 , sorry for the delay. That makes sense, thank you!