search

device-automation-bus / dab-compliance-suite

Compliance Testing Suite for DAB.
https://getdab.org/
3 stars 11 forks source link

No set value for voice/set #35

Open daehyunpark opened 11 months ago

daehyunpark commented 11 months ago

https://github.com/device-automation-bus/dab-compliance-suite/blob/fcf898e295133034baac384c5d049819180b5376/conformance.py#L122

This TC always fails because there is no set value. Can I modify the config.py file to set up the voice system?

arun-madhavan-013 commented 10 months ago

Seems missing parameters, enabled and name in https://github.com/device-automation-bus/dab-compliance-suite/pull/36 As per https://github.com/device-automation-bus/dab-specification-2.0/blob/main/DAB.md#operation-setting-enabled-voice-systems; sample request:

{
   "voiceSystem": {
      "name": "GoogleAssistant",
      "enabled": true
   },
}
arun-madhavan-013 commented 10 months ago

Please review https://github.com/device-automation-bus/dab-compliance-suite/pull/37 which addresses this issue.

daehyunpark commented 10 months ago

There are devices that do not support GoogleAssistant. I suggest adding voice system to config.py.