search

deviceinsight / helm-maven-plugin

Maven Plugin for Helm Charts
Apache License 2.0
46 stars 22 forks source link

chartRepoUrl is required for package goal but can't easily be made optional #39

Closed jmpavlec closed 4 years ago

jmpavlec commented 4 years ago

I created https://github.com/deviceinsight/helm-maven-plugin/pull/38 to show how it could be made optional. For our use case, we don't need to add a chart repo. It appears to already been optional for the deploy phase (although one would argue about whether that should actually be allowed)

I see this has been somewhat covered before: https://github.com/deviceinsight/helm-maven-plugin/issues/5

I'm not sure why using a specific chart repo should be the solution.

kobynet commented 4 years ago

This totally makes for our use-case as well... in our ci/cd server, we have this pre-configured.

pvorb commented 4 years ago

Fixed by #38