search

deviceinsight / kafkactl

Command Line Tool for managing Apache Kafka
https://deviceinsight.github.io/kafkactl/
Apache License 2.0
826 stars 79 forks source link

No configuration for consumer session timeout #153

Open tparsa opened 1 year ago

tparsa commented 1 year ago

Hello,

There are cases where the client needs to increase consumer timeout. The default value set in the sarama library is 10 seconds which might not be enough for example sometimes rebalancing a group takes a while resulting in a timeout.

We can easily use the requestTimeout set in the configuration for all of the timeouts. If this is a valid idea to you I can create a pull request.

d-rk commented 1 year ago

Hi @tparsa

exposing additional timeout configuration from sarama is a valid idea. Which config parameter are you talking about. This one here? https://github.com/Shopify/sarama/blob/main/config.go#L285

Regards, Drk

tparsa commented 1 year ago

Hello @d-rk

Yes, that's the specific timeout that I needed to change. But generally, we can add all of the configurations that the sarama library can use.