search

devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.45k stars 435 forks source link

Add support for the 2020 iPad Pro #235

Closed Zandor300 closed 4 years ago

Zandor300 commented 4 years ago

http://apple.com/ipad-pro

Device Identifiers:

case "iPad8,9", "iPad8,10": return iPadPro11Inch2 // iPad Pro (11-inch) (2nd generation)
case "iPad8,11", "iPad8,12": return iPadPro12Inch4 // iPad Pro (12.9-inch) (4th generation)
devicekit-danger-bot commented 4 years ago
3 Warnings
:warning: Plist changed, don’t forget to localize your plist values
:warning: Source/Device.generated.swift#L683 - Prefer non-optional booleans over optional booleans.
:warning: Source/Device.generated.swift#L1389 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 683 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1389 Prefer empty collection over optional collection.

Generated by :no_entry_sign: Danger

OscarGorog commented 4 years ago

Can we get this pulled please?