search

devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.45k stars 435 forks source link

Fix Xcode 12 warning when depending on Swift package #250

Closed JosephDuffy closed 4 years ago

JosephDuffy commented 4 years ago

A copy of Package.swift with swift-tools-version updated to 5.3 and iOS platform updated to iOS 9.

Having this as a separate file prevents breaking backwards compatibility with Swift < 5.3 projects that support iOS 8.

devicekit-danger-bot commented 4 years ago
1 Warning
:warning: Plist changed, don’t forget to localize your plist values

Generated by :no_entry_sign: Danger

Zandor300 commented 4 years ago

@JosephDuffy Just curious, where is this documented?

JosephDuffy commented 4 years ago

@JosephDuffy Just curious, where is this documented?

I've never found official documentation on it 😕 I published a blog post to try and document it, which references the source code that calls this a "version-specific manifest" but I couldn't find more than that.

Zandor300 commented 4 years ago

After thinking about it and discussing this with @denisenepraunig, I think we should be dropping support for iOS 8. Xcode 12 won't be able to compile for iOS 8 and Apple is known for disallowing uploads from older Xcode versions, so once Xcode 12 is released, people won't be able to support iOS 8 in their apps anyway.

It is a cool contribution and was nice learning about this undocumented feature in Swift Package Manager, but I am going to close this in favor of dropping support for iOS 8.

People who still support iOS 8 currently should remain on the current version of DeviceKit and will be able to update to the (soon to be released) latest version once Apple starts rejecting Xcode 11 uploads.