devicekit-danger-bot
commented
3 years ago | 13 Warnings | |
|---|---|
| :warning: | Plist changed, don’t forget to localize your plist values |
| :warning: | Source/Device.generated.swift#L151 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L153 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L155 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L157 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L159 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L161 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L163 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L165 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L207 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L209 - TODOs should be resolved ()). |
| :warning: | Source/Device.generated.swift#L760 - Prefer non-optional booleans over optional booleans. |
| :warning: | Source/Device.generated.swift#L1495 - Prefer empty collection over optional collection. |
SwiftLint found issues
Warnings
| File | Line | Reason |
|---|---|---|
| Device.generated.swift | 760 | Prefer non-optional booleans over optional booleans. |
| Device.generated.swift | 1495 | Prefer empty collection over optional collection. |
| Device.generated.swift | 151 | TODOs should be resolved ()). |
| Device.generated.swift | 153 | TODOs should be resolved ()). |
| Device.generated.swift | 155 | TODOs should be resolved ()). |
| Device.generated.swift | 157 | TODOs should be resolved ()). |
| Device.generated.swift | 159 | TODOs should be resolved ()). |
| Device.generated.swift | 161 | TODOs should be resolved ()). |
| Device.generated.swift | 163 | TODOs should be resolved ()). |
| Device.generated.swift | 165 | TODOs should be resolved ()). |
| Device.generated.swift | 207 | TODOs should be resolved ()). |
| Device.generated.swift | 209 | TODOs should be resolved ()). |
Generated by :no_entry_sign: Danger
This pull request fixes a couple of bugs introduced in the v4.2.0 release:
Device.allDevicesWithALidarSensordidn't include iPhone 12 Pro and iPhone 12 Pro Max. (#268 #266)Device.iPadAir4.screenRatioreturned an invalid screen ratio. (#268 #267)Fixes https://github.com/devicekit/DeviceKit/issues/267 Fixes https://github.com/devicekit/DeviceKit/issues/266